From dff06bdb5f5dff189277d29c97a7be4d270fef98 Mon Sep 17 00:00:00 2001
From: Christopher Bennell <cbennell@hey.com>
Date: Thu, 9 Jan 2025 10:54:49 -0500
Subject: [PATCH] Add support for Ruby 3.4

---
 CHANGELOG.md            | 2 ++
 README.md               | 2 +-
 builders/ruby.js        | 2 +-
 docs/config.md          | 2 +-
 docs/index.md           | 3 ++-
 examples/3.x/.lando.yml | 5 +++--
 examples/3.x/README.md  | 4 ++--
 7 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 95b92f7..9da4fc7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## {{ UNRELEASED_VERSION }} - [{{ UNRELEASED_DATE }}]({{ UNRELEASED_LINK }})
 
+* Added support for Ruby 3.4
+
 ## v1.4.3 - [December 6, 2024](https://github.com/lando/ruby/releases/tag/v1.4.3)
 
 * Updated the version index.md to get Docuverse page to build correctly.
diff --git a/README.md b/README.md
index c311cf8..7a77002 100644
--- a/README.md
+++ b/README.md
@@ -13,7 +13,7 @@ Add a `ruby` service to your Landofile
 ```yaml
 services:
   myservice:
-    type: ruby:3.3
+    type: ruby:3.4
 ```
 
 For more info you should check out the [docs](https://docs.lando.dev/ruby):
diff --git a/builders/ruby.js b/builders/ruby.js
index 149699b..4390b5d 100644
--- a/builders/ruby.js
+++ b/builders/ruby.js
@@ -8,7 +8,7 @@ module.exports = {
   name: 'ruby',
   config: {
     version: '2.7',
-    supported: ['3.3', '3.2', '3.1', '3.0', '2.7', '2.6', '2.5', '2.4', '2.3', '1.9'],
+    supported: ['3.4', '3.3', '3.2', '3.1', '3.0', '2.7', '2.6', '2.5', '2.4', '2.3', '1.9'],
     patchesSupported: true,
     command: 'tail -f /dev/null',
     legacy: ['3.0', '2.6', '2.5', '2.4', '2.3', '1.9'],
diff --git a/docs/config.md b/docs/config.md
index 3208a18..7a224c4 100644
--- a/docs/config.md
+++ b/docs/config.md
@@ -12,7 +12,7 @@ Also note that the options, in addition to the [build steps](https://docs.lando.
 ```yaml
 services:
   myservice:
-    type: ruby:3.3
+    type: ruby:3.4
     port: 80
     command: tail -f /dev/null
 ```
diff --git a/docs/index.md b/docs/index.md
index 81a41d2..0a76c69 100644
--- a/docs/index.md
+++ b/docs/index.md
@@ -12,6 +12,7 @@ You can easily add it to your Lando app by adding an entry to the [services](htt
 
 ## Supported versions
 
+*   [3.4](https://hub.docker.com/_/ruby)
 *   [3.3](https://hub.docker.com/_/ruby)
 *   [3.2](https://hub.docker.com/_/ruby)
 *   [3.1](https://hub.docker.com/_/ruby)
@@ -42,7 +43,7 @@ To use a patch version, you can do something as shown below:
 ```yaml
 services:
   myservice:
-    type: ruby:3.3.5
+    type: ruby:3.4.1
 ```
 
 But make sure you use one of the available [patch tags](https://hub.docker.com/_/ruby/tags) for the underlying image we are using.
diff --git a/examples/3.x/.lando.yml b/examples/3.x/.lando.yml
index f2342be..219f7e0 100644
--- a/examples/3.x/.lando.yml
+++ b/examples/3.x/.lando.yml
@@ -1,7 +1,7 @@
 name: lando-ruby-3
 services:
   defaults:
-    type: ruby:3.3
+    type: ruby:3.4
     command: ruby /app/server.rb
   custom:
     type: ruby:3.1
@@ -15,7 +15,8 @@ services:
     type: ruby:3.2
   v3_3:
     type: ruby:3.3
-
+  v3_4:
+    type: ruby:3.4
 
 # This is important because it lets lando know to test against the plugin in this repo
 # DO NOT REMOVE THIS!
diff --git a/examples/3.x/README.md b/examples/3.x/README.md
index cb30a72..ec56ce4 100644
--- a/examples/3.x/README.md
+++ b/examples/3.x/README.md
@@ -22,8 +22,8 @@ Verification commands
 Run the following commands to validate things are rolling as they should.
 
 ```bash
-# Should use 3.3.x as the defined version
-lando ssh -s defaults -c "ruby --version | grep 3.3."
+# Should use 3.4.x as the defined version
+lando ssh -s defaults -c "ruby --version | grep 3.4."
 
 # Should use 3.1.x as the defined version
 lando ssh -s custom -c "ruby --version | grep 3.1."