Support limit offset as ExecNode #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
reviewed
Jan 23, 2023
rust/src/io/exec/limit.rs
Outdated
| let nrows = b.num_rows() as i64; | ||
| if off > 0 { | ||
| if off > nrows { | ||
| // skip this batch if offset is more than num rows |
There was a problem hiding this comment.
let's add a todo to skip the read from child entirely if off > nrows?
There was a problem hiding this comment.
this is only useful without any predicates so probably won't be very impactful
| fn poll_next(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Self::Item>> { | ||
| Pin::into_inner(self).rx.poll_recv(cx) | ||
| } | ||
| } |
rust/src/io/exec/limit.rs
Outdated
| /// Create a new execution node to handle limit offset. | ||
| pub fn new( | ||
| child: impl ExecNode + Unpin + Send + 'static, | ||
| limit: Option<i64>, |
There was a problem hiding this comment.
should limit not a Option value
There was a problem hiding this comment.
offline discussion: postgres supports offset without limit
changhiskhan
force-pushed
the
changhiskhan/limit
branch
from
89c4e9b to
48ce7c1
Compare
eddyxu
reviewed
Jan 23, 2023
rust/src/dataset/scanner.rs
Outdated
| @@ -147,6 +147,17 @@ impl<'a> Scanner { | |||
| Arc::new(projection.clone()), | |||
| flat_knn_node, | |||
| )) | |||
| } else if self.limit.is_some() || self.offset.is_some() { | |||
There was a problem hiding this comment.
Could this work with other scanner, i.e., KNN?
for example, should it be the front of the ExecNode so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.