[Rust] Read Partially from a plain encoded batch #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
changed the title
rust/src/encodings/plain.rs
Outdated
| start, end, self.length | ||
| ))); | ||
| } | ||
| let start_offset = match self.data_type { |
There was a problem hiding this comment.
Let’s make a “index_to_offset” function?
| }; | ||
| let range = Range { | ||
| start: self.position, | ||
| end: self.position + array_bytes, | ||
| start: self.position + start_offset, |
There was a problem hiding this comment.
I vaguely remember that the C++ implementation was more complicated than this. Any edge cases that’s not covered here?
There was a problem hiding this comment.
This does not cover the logic in C++ PlainEncoder::Take(indices) yet.
For C++, PlainEncoder::ToArray(...) this PR reaches the parity.
https://github.com/eto-ai/lance/blob/main/cpp/src/lance/encodings/plain.cc#L127-L149
Added 2 more tests to cover edge cases nonetheless.
changhiskhan
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.