Add GADT symbols when typing typing-ahead lambda bodies #19644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested changes
Feb 19, 2024
smarter
approved these changes
Feb 22, 2024
|
What's the correct way to request a backport of this to 3.4.1-RC2? |
|
Why would reset the release train for this? Can't it just go in the next release? |
|
Because it fixes a regression. I don't think backporting fixes should require delaying the release: Rust does backport and never delays their releases (https://doc.rust-lang.org/book/appendix-07-nightly-rust.html), but I guess if this is our policy currently then not much point in backporting yeah. |
|
Good points. |
dwijnand
added
the
backport:nominated
Kordyjan
added a commit
that referenced
this pull request
Feb 29, 2024
Kordyjan
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19570