-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
classfile reader: handle JDK 9+ constant types in constant pool #19533
Conversation
I did verify locally, on JDK 21, that the test failed before the change and succeeded afterwards
|
@SethTisue there is |
3f7369c
to
0bfacf0
Compare
thx @som-snytt — I've updated the PR to use that. |
I've added a commit forward-porting @lrytz's |
Pull request was converted to draft
I've converted this back to a draft, because in porting Lukas's test, I noticed that Dotty's |
Co-authored-by: Lukas Rytz <[email protected]>
forward-port of scala/scala#10675 and scala/scala#8595 references scala/bug#12396 and scala/bug#11635 fixes #19527 ("bad constant pool tag 17") also fixes unreported potential "bad constant pool tag 19" and "bad constant pool tag 20" errors
e92043d
to
26852de
Compare
Okay, I went back and added the additional constants from scala/bug#11635 . I did not forward-port the additional test from scala/scala#8595 . It is Scaladoc-based and did not trigger the bug on Scala 3, and I don't know how else to trigger it. |
@Kordyjan should I backport it myself, or just figure it will happen...? |
I will handle that before 3.3.3. |
forward-port of scala/scala#10675 and scala/scala#8595
references scala/bug#12396 and scala/bug#11635
fixes #19527 ("bad constant pool tag 17")
also fixes unreported potential "bad constant pool tag 19" and "bad constant pool tag 20" errors
should be backported to 3.3.x, IMO