Deprecate Quotes {MethodType,TermParamClause}.isErased
#18479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods should not have been stabiliezed in the first place. Now that we can mark individual parameters as erased, this method is fundamentally broken.
nicolasstucki
force-pushed
the
deprecate-isErased
branch
from
03eab2b to
7726056
Compare
nicolasstucki
requested review from
bishabosha
and removed request for
Kordyjan
bishabosha
reviewed
Dec 19, 2023
| @@ -4364,7 +4360,7 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching => | |||
| * - ... | |||
| * - Nth element is `FunctionN` | |||
| */ | |||
| @deprecated("Use overload of `FunctionClass` with 1 or 2 arguments","3.4") | |||
| @deprecated("Use overload of `FunctionClass` with 1 or 2 arguments", "3.4") | |||
There was a problem hiding this comment.
unrelated to this PR but this message seems ambiguous if we were to add another overload with 1 or 2 arguments, we might not catch it at the time those hypothetical methods would be added
bishabosha
approved these changes
Dec 19, 2023
bishabosha
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods should not have been stabiliezed in the first place. Now that we can mark individual parameters as erased, this method is fundamentally broken.
Related to #18472