-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MT separate compilation bug #18398
Conversation
@odersky There's a few things that go wrong to cause this:
I went for the narrow fix, but I'm open to addressing bigger issues. What do you think we should do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks OK to me as far as I can tell, but I am really out of my depth here. I propose to add @sjrd as a reviewer of match type issues; he has far more up-to-date knowledge of the issues than I do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Also I checked that it has the same effect if rebased on the new match types branch (i.e., the new test fails without the fix and succeeds with it).
Unfortunately, continuing the "short blanket" phenomenon, this PR apparently causes a new regression #18448 (although I'm not sure this code was supposed to compile to begin with). |
No description provided.