Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasMatchingMember handling NoDenotation #17977

Merged

Conversation

dwijnand
Copy link
Member

Fixes #17581

@dwijnand dwijnand force-pushed the fix-hasMatchingMember-handling-NoDenotation branch from 630ed04 to 08d4d59 Compare June 17, 2023 10:38
@dwijnand dwijnand marked this pull request as ready for review June 18, 2023 08:52
@dwijnand
Copy link
Member Author

Needs a rerun, maybe a rebase, to get past #17993.

@mbovel
Copy link
Member

mbovel commented Jun 19, 2023

Yes, I think you'll need to rebase on or after ac2879e.

@dwijnand dwijnand force-pushed the fix-hasMatchingMember-handling-NoDenotation branch 2 times, most recently from 3dd0677 to 4373d48 Compare June 20, 2023 08:11
@dwijnand dwijnand requested a review from mbovel June 20, 2023 08:13
@dwijnand dwijnand assigned mbovel and odersky and unassigned mbovel Jun 20, 2023
@dwijnand dwijnand requested review from odersky and removed request for mbovel June 26, 2023 08:16
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@odersky odersky merged commit bbb70cc into scala:main Jun 26, 2023
@dwijnand dwijnand deleted the fix-hasMatchingMember-handling-NoDenotation branch June 26, 2023 13:11
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Soundness bug in structural types
4 participants