Only include accessible base classes in orDominator #16477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By joining union types we could previously uncover inaccessible base classes that could lead to access errors at runtime. We now filter out such classes when computing the orDominator. Fixes scala#16474
|
It seems JSCompilationTests runs tests in tests/run but fails since there are Java |
|
You can skip a test when running with scala.js by adding as a first line in the test file: // scalajs: --skipFor multi files test you can put in just one file like in https://github.com/lampepfl/dotty/blob/main/tests/run/java-longnames/Test_2.scala |
Add a magical comment instead of moving test
|
@smarter Thanks for the tip! |
smarter
approved these changes
Dec 7, 2022
smarter
added
the
backport:nominated
Kordyjan
added
backport:accepted
Kordyjan
added a commit
that referenced
this pull request
Dec 22, 2022
Kordyjan
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By joining union types we could previously uncover inaccessible base classes that could lead to access errors at runtime. We now filter out such classes when computing the orDominator.
Fixes #16474