feat: [SemanticDB] support LambdaType (convert from HKTypeLambda) #16056

tanishiking · 2022-09-16T12:28:07Z

based on the new semanticdb schema
scalameta/scalameta#2867
tanishiking/semanticdb-for-scala3@3981424

This commit adds support for LambdaType that is converted from HKTypeLambda in Scala3.

For example, the following type signature
[A, B] =>> [C] =>> A | B | C

will be

LambdaType(
  parameters = Some(
    value = Scope(hardlinks =
      List(
        "....Union#[A]"
        "....Union#[B]"
      ), symlinks = List()
    )
  ),
  returnType = LambdaType(
    parameters = Some(
      value = Scope(hardlinks = List("....Union#[C]"), symlinks = List())
    ),
    returnType = UnionType(
      types = List(
        TypeRef(
          prefix = Empty,
          symbol = "....Union#[A]",
          typeArguments = List()
        ),
        TypeRef(
          prefix = Empty,
          symbol = "....Union#[B]",
          typeArguments = List()
        ),
        TypeRef(
          prefix = Empty,
          symbol = "....Union#[C]",
          typeArguments = List()
        )
      )
    )
  )
)

I'm wondering...

Previously, we embed type Id = [A] =>> A which is equivalent to type Id[A] = A
https://github.com/lampepfl/dotty/blob/afc6ce4d2135e3532bf28146a7700d2cc4338e90/compiler/src/dotty/tools/dotc/semanticdb/TypeOps.scala#L218-L231
because we didn't have a way to express [A] =>> A in SemanticDB.

Now we support LambdaType in SemanticDB, maybe we can save type Id[A] = A as type Id = [A] =>> A instead of converting it to type Id[A] = A when converting the signature into SemanticDB. 🤔

bishabosha · 2022-09-16T14:19:34Z

tests/semanticdb/expect/hk.expect.scala

+  def flatMap/*<-hk::Monad#flatMap().*/[A/*<-hk::Monad#flatMap().[A]*/, B/*<-hk::Monad#flatMap().[B]*/](m/*<-hk::Monad#flatMap().(m)*/: M/*->hk::Monad#[M]*/[A/*->hk::Monad#flatMap().[A]*/])(f/*<-hk::Monad#flatMap().(f)*/: A/*->hk::Monad#flatMap().[A]*/ => M/*->hk::Monad#[M]*/[B/*->hk::Monad#flatMap().[B]*/]): M/*->hk::Monad#[M]*/[B/*->hk::Monad#flatMap().[B]*/] = ???/*->scala::Predef.`???`().*/
+}
+
+class EitherMonad/*<-hk::EitherMonad#*/[T/*<-hk::EitherMonad#[T]*/] extends Monad/*->hk::Monad#*/[[E/*<-hk::EitherMonad#`<init>`().[E]*/] =>> Either/*->scala::package.Either#*/[T/*->hk::EitherMonad#[T]*/, E]] {


the lack of reference recorded for E when passed to Either I guess is the usual problem that it is backed by TypeTree?

Yeah, it seems like so, I'll take a look in another PR :)

bishabosha · 2022-09-16T14:22:10Z

tests/semanticdb/metac.expect

+hk/hk$package. => final package object hk extends Object { self: hk.type => +4 decls }
+hk/hk$package.Id# => type Id [typeparam A ] = A
+hk/hk$package.Id#[A] => typeparam A 
+hk/hk$package.MapKV# => type MapKV [typeparam K ] = [V] =>> Map[K, V]


I wonder how a curried type lambda would look with three argument lists, does it nest?

yes, it will nest like this https://github.com/lampepfl/dotty/pull/16056/files#diff-18e8342519c9145a646a9b86ca13f58300b3fff458b90420ef3bb7e3e8bdd56fR4005 (force pushed the test)

bishabosha · 2022-09-16T14:23:13Z

looks good!

bishabosha · 2022-09-20T10:07:25Z

tests/semanticdb/expect/hk.expect.scala

+
+type MapV/*<-hk::hk$package.MapV#*/ = [_] =>> [V/*<-hk::hk$package.MapV#[V]*/] =>> Map/*->scala::Predef.Map#*/[String/*->scala::Predef.String#*/, V/*->hk::hk$package.MapV#[V]*/]
+
+type MapEither/*<-hk::hk$package.MapEither#*/ = [K/*<-hk::hk$package.MapEither#[K]*/] =>> [L/*<-hk::hk$package.MapEither#[L]*/] =>> [R/*<-hk::hk$package.MapEither#[R]*/] =>> Map/*->scala::Predef.Map#*/[K/*->hk::hk$package.MapEither#[K]*/, Either/*->scala::package.Either#*/[L/*->hk::hk$package.MapEither#[L]*/, R/*->hk::hk$package.MapEither#[R]*/]]


question for those who know semanticdb the best, should these lambda params after the first list be local symbols? like types in a refinement

@tgodzik @olafurpg

I think so yeah, if they cannot be accessed from the outside these can be local params.

bishabosha · 2023-03-27T07:45:25Z

I'm not sure what happened here, sorry! but now it needs another rebase

tanishiking · 2023-04-14T05:24:31Z

Hey, I rebased on the latest main 👍

bishabosha · 2023-04-14T10:15:04Z

seems like tests/neg-custom-args/fatal-warnings/i15503g.scala is now failing the tests with some unused parameters warnings

scalameta/scalameta#2867 This commit adds support for LambdaType that is converted from HKTypeLambda in Scala3

tanishiking mentioned this pull request Sep 16, 2022

feat: Add support for LambdaType (corresponds to Scala3 HKTypeLambda) scalameta/scalameta#2867

Merged

tanishiking marked this pull request as ready for review September 16, 2022 14:07

bishabosha self-requested a review September 16, 2022 14:14

bishabosha self-assigned this Sep 16, 2022

bishabosha reviewed Sep 16, 2022

View reviewed changes

bishabosha approved these changes Sep 16, 2022

View reviewed changes

tanishiking force-pushed the type-lambda branch from 08fca16 to 399f229 Compare September 19, 2022 09:20

bishabosha reviewed Sep 20, 2022

View reviewed changes

tanishiking force-pushed the type-lambda branch from 9fe0047 to 5e78f68 Compare April 14, 2023 05:24

tanishiking force-pushed the type-lambda branch from 5e78f68 to 9b678fd Compare April 14, 2023 06:45

bishabosha mentioned this pull request Apr 14, 2023

correctly type Expr.ofTupleFromSeq for arity > 22 #17261

Merged

feat: [SemanticDB] support LambdaType (convert from HKTypeLambda)

06226b1

scalameta/scalameta#2867 This commit adds support for LambdaType that is converted from HKTypeLambda in Scala3

bishabosha force-pushed the type-lambda branch from 9b678fd to 06226b1 Compare April 24, 2023 14:14

bishabosha enabled auto-merge April 24, 2023 14:15

bishabosha merged commit 65bb700 into scala:main Apr 24, 2023

Kordyjan added this to the 3.3.1 milestone Aug 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [SemanticDB] support LambdaType (convert from HKTypeLambda) #16056

feat: [SemanticDB] support LambdaType (convert from HKTypeLambda) #16056

tanishiking commented Sep 16, 2022 •

edited

Loading

bishabosha Sep 16, 2022 •

edited

Loading

tanishiking Sep 19, 2022

bishabosha Sep 16, 2022

tanishiking Sep 19, 2022

bishabosha commented Sep 16, 2022

bishabosha Sep 20, 2022

bishabosha Sep 20, 2022

tgodzik Sep 20, 2022

bishabosha commented Mar 27, 2023 •

edited

Loading

tanishiking commented Apr 14, 2023

bishabosha commented Apr 14, 2023


		type MapV/<-hk::hk$package.MapV#/ = [_] =>> [V/<-hk::hk$package.MapV#[V]/] =>> Map/->scala::Predef.Map#/[String/->scala::Predef.String#/, V/->hk::hk$package.MapV#[V]/]

		type MapEither/<-hk::hk$package.MapEither#/ = [K/<-hk::hk$package.MapEither#[K]/] =>> [L/<-hk::hk$package.MapEither#[L]/] =>> [R/<-hk::hk$package.MapEither#[R]/] =>> Map/->scala::Predef.Map#/[K/->hk::hk$package.MapEither#[K]/, Either/->scala::package.Either#/[L/->hk::hk$package.MapEither#[L]/, R/->hk::hk$package.MapEither#[R]/]]

feat: [SemanticDB] support LambdaType (convert from HKTypeLambda) #16056

feat: [SemanticDB] support LambdaType (convert from HKTypeLambda) #16056

Conversation

tanishiking commented Sep 16, 2022 • edited Loading

I'm wondering...

bishabosha Sep 16, 2022 • edited Loading

Choose a reason for hiding this comment

tanishiking Sep 19, 2022

Choose a reason for hiding this comment

bishabosha Sep 16, 2022

Choose a reason for hiding this comment

tanishiking Sep 19, 2022

Choose a reason for hiding this comment

bishabosha commented Sep 16, 2022

bishabosha Sep 20, 2022

Choose a reason for hiding this comment

bishabosha Sep 20, 2022

Choose a reason for hiding this comment

tgodzik Sep 20, 2022

Choose a reason for hiding this comment

bishabosha commented Mar 27, 2023 • edited Loading

tanishiking commented Apr 14, 2023

bishabosha commented Apr 14, 2023

tanishiking commented Sep 16, 2022 •

edited

Loading

bishabosha Sep 16, 2022 •

edited

Loading

bishabosha commented Mar 27, 2023 •

edited

Loading