Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix treatment of parameter selections via this in constructors. #15737

Merged
merged 3 commits into from
Jul 23, 2022
Merged

Fix treatment of parameter selections via this in constructors. #15737

merged 3 commits into from
Jul 23, 2022

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jul 22, 2022

Fixes #15723

odersky added 2 commits July 23, 2022 10:46
@odersky
Fix comment
3d50596
@odersky
Unrelated tests
4710941 
I piggyback these here to not go through the ceremony of another PR
@odersky odersky requested a review from liufengyun July 23, 2022 10:33
liufengyun
liufengyun approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit 1b299b3 into scala:main Jul 23, 2022
@odersky odersky deleted the fix-15723 branch July 23, 2022 19:58
@liufengyun liufengyun mentioned this pull request Jul 23, 2022
Closed
@Kordyjan Kordyjan added this to the 3.2.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@som-snytt som-snytt som-snytt left review comments

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

The meaning of this.field in class body
4 participants
@odersky @som-snytt @liufengyun @Kordyjan