Set ACC_FINAL access flag to final variable accessors #15707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
force-pushed
the
fix/i10835-final-vars
branch
from
dfe36a5 to
eab6d19
Compare
odersky
approved these changes
Jul 21, 2022
| @@ -310,7 +310,7 @@ class BTypesFromSymbols[I <: DottyBackendInterface](val int: I) extends BTypes { | |||
| // tests/run/serialize.scala and https://github.com/typelevel/cats-effect/pull/2360). | |||
| val privateFlag = !sym.isClass && (sym.is(Private) || (sym.isPrimaryConstructor && sym.owner.isTopLevelModuleClass)) | |||
|
|
|||
| val finalFlag = sym.is(Final) && !toDenot(sym).isClassConstructor && !sym.is(Mutable) && !sym.enclosingClass.is(Trait) | |||
| val finalFlag = sym.is(Final) && !toDenot(sym).isClassConstructor && (!sym.is(Mutable) || sym.is(Accessor)) && !sym.enclosingClass.is(Trait) | |||
There was a problem hiding this comment.
Suggested change
| val finalFlag = sym.is(Final) && !toDenot(sym).isClassConstructor && (!sym.is(Mutable) || sym.is(Accessor)) && !sym.enclosingClass.is(Trait) | |
| val finalFlag = sym.is(Final) && !toDenot(sym).isClassConstructor && !sym.is(Mutable, butNot = Accessor) && !sym.enclosingClass.is(Trait) |
There was a problem hiding this comment.
This is slightly shorter and more efficient, but not sure it's worth it actually.
WojciechMazur
force-pushed
the
fix/i10835-final-vars
branch
from
eab6d19 to
51be2dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10835
ACC_FINAL flag was never set for the accessors - they were filtered out by
!sym.is(Mutable)condition