Better infos for dependent class parameter references #15667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We sometimes create a dependent parameter reference p.X where `p` is a path with a type that has a wildcard argument, e.g. `P[X >: L <: H].` So far the denotation of `p.X` had as info the bounds with which `X` was declared in `P`. Now it gets the actual parameter bounds instead. Fixes scala#15652 scala#15652 started failing when tuple unpackings started to use `val`s instead of `def`s in scala#14816. That caused dependent class parameter references to be created and uncovered the problem.
mbovel
approved these changes
Jul 15, 2022
Kordyjan
added
the
backport:accepted
Kordyjan
added
backport:done
Kordyjan
added a commit
that referenced
this pull request
Jul 27, 2022
Backport #15667: Better infos for dependent class parameter references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes create a dependent parameter reference p.X where
pis a path with a type that has a wildcard argument, e.g.P[X >: L <: H].So far the denotation of
p.Xhad as info the bounds with whichXwasdeclared in
P. Now it gets the actual parameter bounds>: L <: Hinstead.Fixes #15652
#15652 started failing when tuple unpackings started to use
vals instead ofdefsin #14816. That caused dependent class parameter references to be created and uncovered
the problem.