implement scalac script in Scala #15212

bishabosha · 2022-05-18T09:18:55Z

fixes #15173
fixes #15221

bishabosha · 2022-05-18T14:27:02Z

@michelou also tagging you here for when this is merged

bishabosha · 2022-05-18T15:36:22Z

tested in project/scripts/winCmdTests and project/scripts/bootstrappedOnlyCmdTests

dist/bin/scalac

compiler/src/dotty/tools/MainGenericCompiler.scala

sjrd · 2022-05-19T09:21:37Z

dist/bin/scalac

+      addScala "$1"
+      shift
+      ;;
+    -classpath*)


Same confusion here. This did not use to be special in the old script. Why is it special now?

This is copied from the Scala script, I think there was the same Cygwin bug there

I don't think it's related to cygwin; the code and comments appear to be inherited from the scala2 version of the script.

sjrd · 2022-05-19T09:23:45Z

dist/bin/scalac

+   "-Dscala.usejavacp=true" \
+   "-Dscala.home=$PROG_HOME" \


Are these things that the cs runner would be able to pass to MainGenericRunner?

CS can configure properties, but probably does not have a magic variable for the launch directory (-Dscala.home was copied from the Scala script for use in programs), I don't think it should be supported in CS because the directory structure is not equivalent

Some scripts will fail if -Dscala.home=$PROG_HOME isn't defined.
And there is no simple alternative to figuring out the path to the current runtime scala.
Different scripts can specify different versions of scala via the hashbang line, so environment variables can't be relied on. See #13758
It might not matter for non-script code, although it can be useful there as well.

I've had a look and we can check if the property coursier.mainJar is set, which will be the path of the coursier launcher script - we can then use that to set scala.home to the parent directory. - problem here is that using the native script then scala is at s"${sys.props("scala.home")}/bin/scala", but for coursier it is s"${sys.props("scala.home")}/scala" (we could go one directory above to preserve /bin but I think this won't work on a custom Coursier install dir. [edit: I checked and for windows the default it also in some /bin directory])

Idea from @sjrd it could likely be much more useful to provide properties that have the classpath of the scala compiler and scala standard libraries, that can be provided as arguments to the java command, this is more uniform than a fragile directory structure that depends on the package manager.

I like this suggestion, it would then be possible to find the first scala3-library*.jar in the classpath, and two directories up would be scala.home.

bishabosha · 2022-05-19T21:18:52Z

@philwalk I've added again a minimal version of the changes to run the shebang scripts on macOS - but I would need advice on if this is a problem for testing unglobClasspath.sc

Edit: moved to #15241

sjrd

I don't know about the changes with #!/usr/bin/env -S bin/scala, but otherwise LGTM.

compiler/test-resources/scripting/unglobClasspath.sc

bishabosha · 2022-05-20T08:55:36Z

compiler/test-resources/scripting/unglobClasspath.sc


 // won't compile unless the hashbang line sets classpath
-import org.jline.terminal.Terminal
+import org.jsoup.Jsoup


for clarification: jline is included in the compiler toolchain by dist/bin/common, so the -classpath 'dist/target/pack/lib/*' is not necessary. However Jsoup is in the lib directory, making the import break without it.

bishabosha · 2022-05-20T09:01:14Z

I will open a new PR with the shebang changes (Edit: see #15241)

philwalk · 2022-05-20T13:56:32Z

Looks good

bishabosha · 2022-05-23T10:48:22Z

do you think we can backport this to the 3.1.3 branch? - It would be good to get this as soon as possible into Coursier's scalac script

bishabosha added the area:scripting label May 18, 2022

bishabosha added this to the 3.2.0-RC1 milestone May 18, 2022

This comment was marked as outdated.

Sign in to view

bishabosha force-pushed the main-generic-compiler branch from 6326fb7 to 9f03cf5 Compare May 18, 2022 13:25

bishabosha closed this May 18, 2022

bishabosha force-pushed the main-generic-compiler branch from 9f03cf5 to e5abec0 Compare May 18, 2022 13:54

bishabosha reopened this May 18, 2022

bishabosha added the needs-minor-release This PR cannot be merged until the next minor release label May 18, 2022

bishabosha requested review from philwalk, Kordyjan and BarkingBad May 18, 2022 14:20

bishabosha marked this pull request as ready for review May 18, 2022 14:22

bishabosha assigned Kordyjan May 18, 2022

bishabosha requested a review from michelou May 18, 2022 14:26

bishabosha changed the title ~~add MainGenericCompiler~~ implement scalac script in Scala May 18, 2022

bishabosha assigned sjrd and unassigned Kordyjan May 19, 2022

bishabosha requested a review from sjrd May 19, 2022 07:46

sjrd requested changes May 19, 2022

View reviewed changes

bishabosha force-pushed the main-generic-compiler branch 3 times, most recently from a8a2bc8 to 98d5f9d Compare May 19, 2022 15:30

bishabosha requested a review from sjrd May 19, 2022 16:06

bishabosha force-pushed the main-generic-compiler branch 2 times, most recently from 3b1413b to 37bcdb3 Compare May 19, 2022 18:46

bishabosha mentioned this pull request May 19, 2022

BashScriptsTests seems to be broken on macOS #15221

Open

This comment was marked as outdated.

Sign in to view

bishabosha force-pushed the main-generic-compiler branch from 37bcdb3 to e15cfa9 Compare May 19, 2022 18:51

bishabosha force-pushed the main-generic-compiler branch 2 times, most recently from 646cf10 to 7e05e4e Compare May 19, 2022 20:53

bishabosha force-pushed the main-generic-compiler branch from 989327a to 0529979 Compare May 19, 2022 21:22

bishabosha added 3 commits May 20, 2022 08:27

add MainGenericCompiler

52a871f

add explicit tests of scalac flags

be701d4

address review comments

a117aff

bishabosha force-pushed the main-generic-compiler branch from 0529979 to aa554da Compare May 20, 2022 06:28

sjrd approved these changes May 20, 2022

View reviewed changes

bishabosha commented May 20, 2022

View reviewed changes

compiler/test-resources/scripting/unglobClasspath.sc Outdated Show resolved Hide resolved

bishabosha commented May 20, 2022

View reviewed changes

bishabosha force-pushed the main-generic-compiler branch from aa554da to a117aff Compare May 20, 2022 09:00

bishabosha enabled auto-merge May 20, 2022 09:00

bishabosha merged commit 83b90d8 into scala:main May 20, 2022

bishabosha deleted the main-generic-compiler branch May 20, 2022 10:26

bishabosha added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label May 23, 2022

bishabosha added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels May 23, 2022

bishabosha mentioned this pull request May 23, 2022

[backport] add MainGenericCompiler #15275

Merged

smarter added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jul 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement scalac script in Scala #15212

implement scalac script in Scala #15212

bishabosha commented May 18, 2022 •

edited

Loading

This comment was marked as outdated.

bishabosha commented May 18, 2022 •

edited

Loading

bishabosha commented May 18, 2022

sjrd May 19, 2022

bishabosha May 19, 2022

philwalk May 19, 2022

sjrd May 19, 2022

bishabosha May 19, 2022 •

edited

Loading

philwalk May 19, 2022 •

edited

Loading

bishabosha May 19, 2022 •

edited

Loading

bishabosha May 20, 2022 •

edited

Loading

philwalk May 20, 2022

This comment was marked as outdated.

bishabosha commented May 19, 2022 •

edited

Loading

sjrd left a comment

bishabosha May 20, 2022

bishabosha commented May 20, 2022 •

edited

Loading

philwalk commented May 20, 2022

bishabosha commented May 23, 2022

implement scalac script in Scala #15212

implement scalac script in Scala #15212

Conversation

bishabosha commented May 18, 2022 • edited Loading

This comment was marked as outdated.

bishabosha commented May 18, 2022 • edited Loading

bishabosha commented May 18, 2022

sjrd May 19, 2022

Choose a reason for hiding this comment

bishabosha May 19, 2022

Choose a reason for hiding this comment

philwalk May 19, 2022

Choose a reason for hiding this comment

sjrd May 19, 2022

Choose a reason for hiding this comment

bishabosha May 19, 2022 • edited Loading

Choose a reason for hiding this comment

philwalk May 19, 2022 • edited Loading

Choose a reason for hiding this comment

bishabosha May 19, 2022 • edited Loading

Choose a reason for hiding this comment

bishabosha May 20, 2022 • edited Loading

Choose a reason for hiding this comment

philwalk May 20, 2022

Choose a reason for hiding this comment

This comment was marked as outdated.

bishabosha commented May 19, 2022 • edited Loading

sjrd left a comment

Choose a reason for hiding this comment

bishabosha May 20, 2022

Choose a reason for hiding this comment

bishabosha commented May 20, 2022 • edited Loading

philwalk commented May 20, 2022

bishabosha commented May 23, 2022

bishabosha commented May 18, 2022 •

edited

Loading

bishabosha commented May 18, 2022 •

edited

Loading

bishabosha May 19, 2022 •

edited

Loading

philwalk May 19, 2022 •

edited

Loading

bishabosha May 19, 2022 •

edited

Loading

bishabosha May 20, 2022 •

edited

Loading

bishabosha commented May 19, 2022 •

edited

Loading

bishabosha commented May 20, 2022 •

edited

Loading