fix: use correct ErrorMessageID for EmptyCatchOrFinallyBlock #14786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were always assigning this to
EmptyCatchOrFinallyBlockID
but both
EmptyCatchBlock
andEmptyCatchAndFinallyBlock
both use thisclass and pass in their corresponding
ErrorMessageID
. This caused thefollowing two code samples to give the same
ErrorMessageID
when theyshould have been different:
try {}
The second one gave this as an error:
When the ID should be
E001
,EmptyCatchBlockId
. Now this correctlyreturns:
The first example should actually be using
E002
since it's missing both thecatch and finally blocks.