Fix hoisting local symbols #14714
Merged
Fix hoisting local symbols #14714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous algorithm computed a "logical owner" of term-owned symbols from dependencies. But it would switch back from the computed logical owner to the enclosing class under certain conditions. The problem is that such a decision cannot be done independently for each symbol, since it also affects dependent symbols. We now move this distinction into the logical owner initialization itself, instead of doing it as a post processing step. Fixes scala#14707
dwijnand
approved these changes
Mar 21, 2022
|
Yes, lambdaLift is terra incognita for many, even though it performs a crucial function. I believe @DarkDimius was the only other person who ever worked on it (the code I touched was written originally by him). |
|
If people want to learn some of the key steps of compiling Scala, lambdaLift is not a bad start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous algorithm computed a "logical owner" of term-owned symbols
from dependencies. But it would switch back from the computed logical
owner to the enclosing class under certain conditions. The problem is
that such a decision cannot be done independently for each symbol, since
it also affects dependent symbols. We now move this distinction into
the logical owner initialization itself, instead of doing it as a
post processing step.
Fixes #14707