Tolerate some faults when copying trees in InlineTreeMap #14674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a preparatory step the inliner maps the inlined body with a tree type map. This map adjusts the tree and at the same time sets up the environment for typing the tree. But this has the potential that re-typing during copying will fail since the environment is not yet set up correctly. We avoid the problem by ignoring a specific failure (function type in application does not exist) and proceeding with the previous type.
nicolasstucki
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preparatory step the inliner maps the inlined body with a tree type map.
This map adjusts the tree and at the same time sets up the environment for
typing the tree. But this has the potential that re-typing during copying
will fail since the environment is not yet set up correctly. We avoid the
problem by ignoring a specific failure (function type in application does
not exist) and proceeding with the previous type.