feat(repl): autocomplete repl commands #14627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prolativ
reviewed
Mar 7, 2022
prolativ
reviewed
Mar 7, 2022
This adds in completion for the available commands in the repl just like there is for Scala 2. For example you can do `:@@` which will give you back all the commands.
In the situation where we have `:im<tab>` normally `:` and `im` would be split into two tokens and it would result in `::imports`. Instead, we detect early if we are about to complete a command and instead of parsing it normally like Scala we just grab the entire thing as the word.
|
Alright, I think I have the issues addressed now. In the case where you're about to complete a command we detect it early in |
|
Nice. The Scala 2 fix was a year ago with I guess similar insight, I've totally forgotten. I'll migrate "understand jline" from last year's new year's resolutions. |
prolativ
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in completion for the available commands in the repl just like
there is for Scala 2. For example you can do
:@@which will give youback all the commands.