Only make the staged parts of a quote inlineable #14604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
reviewed
Mar 2, 2022
Contents of splices do not need to be transformed as they will be evaluated before the code is inlined. Therefore we only want to make code at staging level 1 or grater inlineable. If the quote is in an inline method, we also need to make the contents of the splices inlineable (i.e. for any level). Fix scala#14603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents of splices do not need to be transformed as they will be
evaluated before the code is inlined. Therefore we only want to make
code at staging level 1 or grater inlineable. If the quote is in an
inline method, we also need to make the contents of the splices
inlineable (i.e. for any level).
Fix #14603