Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ownership changes in InlineTyper #14568

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Feb 25, 2022

Fixes a part of #13334 which now works for transparent inline.

The minimized example

class Bar

inline def bar(i: Int): Bar =
  new Bar:
    def j = i

class Foo(x: Int):
  def foo = bar(x)

now works also for inline. But the original example fails with an unrelated error (wrong source position). I verified that
this error occurs even with the inliner before the PR if we turn off ownership checking. So the source position error
was simply masked before by the ownership error, which happened before.

I updated #13334 to reflect the new state.

Fixes a part of scala#13334 which now works for `transparent inline`.
@odersky
Copy link
Contributor Author

odersky commented Mar 6, 2022

@nicolasstucki ping for review

@nicolasstucki nicolasstucki merged commit dfdd31a into scala:main Mar 7, 2022
@nicolasstucki nicolasstucki deleted the fix-13334 branch March 7, 2022 08:48
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants