Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin interop: Find nested class if InnerClass entry is missing #14426

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

smarter
Copy link
Member

@smarter smarter commented Feb 7, 2022

This is a port of scala/scala#5822 which works
around a bug in Kotlin (https://youtrack.jetbrains.com/issue/KT-27936).

Fixes #12086.

Co-Authored-By: Lukas Rytz [email protected]
Co-Authored-By: Brandon Barker [email protected]

@smarter smarter force-pushed the issue/12086-kotlin-interop branch from b590482 to 681e17e Compare February 7, 2022 14:13
This is a port of scala/scala#5822 which works
around a bug in Kotlin (https://youtrack.jetbrains.com/issue/KT-27936).

Fixes scala#12086.

Co-Authored-By: Lukas Rytz <[email protected]>
Co-Authored-By: Brandon Barker <[email protected]>
Copy link
Contributor

@Kordyjan Kordyjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Also, the tests are really clever :)

@smarter smarter merged commit 482c67e into scala:main Mar 4, 2022
@smarter smarter deleted the issue/12086-kotlin-interop branch March 4, 2022 14:57
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin interop: reporting wrong type for inner classes appearing in Kotlin method types
3 participants