-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix case null on non-nullable type in unsafe nulls #13976
Conversation
Defer this PR until after #14346 has been considered and either implemented or rejected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the sticky-key trick will not work if we compile from Tasty. At least we never used attachments to convey info from typer to a phase after pickling, to my knowledge. I believe we can do better by keeping the imports around until PatternMatcher, as suggested by #14346.
2866349
to
d296dd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix
case null => ???
on non-nullable type in unsafe nulls, we should not get Match case Unreachable Warning.Since we don't have import information after frontend, a StickyKey on match tree is used to pass Unsafe Nulls information to later PatternMatcher Phase.