Fix #13221: Set JavaStatic on Module fields of module classes in JSCodeGen. #13381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JSCodeGen. This replicates what the JVM back-end does, to some extent, and is necessary for desugarIdent not to crash in obscure cases. We also remove an unnecessary call to desugarIdent.
smarter
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
By the way, there's a def desugarIdent in JSCodeGen and a comment above that says "Copied from DottyBackendInterface" but this method has been renamed cachedDesugarIdent in DottyBackendInterface, it would be nice to harmonize JSCodeGen with this (and possibly other changes in DottyBackendInterface?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replicates what the JVM back-end does, to some extent, and is necessary for
desugarIdentnot to crash in obscure cases.We also remove an unnecessary call to
desugarIdent.