Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for laminas/laminas-servicemanager 4.0 so this library can be used on PHP 8.2 + psr/container 2.0. #75

Closed
MegaChriz opened this issue Jul 20, 2023 · 4 comments
Assignees
Milestone

Comments

@MegaChriz
Copy link

I maintain a Drupal module called "Feeds". Wit that module you can import content on a Drupal site. It uses laminas/laminas-feed to parse RSS feeds.

The issue is that Feeds cannot be installed currently on Drupal 10 + PHP 8.2 because Drupal 10 requires psr/container ~2.0.2 and only laminas/laminas-servicemanager 4.0.x is compatible with PHP 8.2 + psr/container ~2.0.2. (For some reason though laminas/laminas-servicemanager 3.15 is compatible with psr/container 2.0.2 too, but not with PHP 8.2, hence the reason why my module is installable on Drupal 10 + PHP 8.1.)

Anyway, it would help if this project can declare a compatibility with laminas/laminas-servicemanager ^4.0.

See also https://www.drupal.org/project/feeds/issues/3325568

@froschdesign
Copy link
Member

@MegaChriz

(For some reason though laminas/laminas-servicemanager 3.15 is compatible with psr/container 2.0.2 too

This was a mistake; more here: laminas/laminas-servicemanager#147

Anyway, it would help if this project can declare a compatibility with laminas/laminas-servicemanager ^4.0.

Version 4 of laminas-servicemanager has not yet been released. Only two pre-releases: https://github.com/laminas/laminas-servicemanager/releases

@froschdesign
Copy link
Member

@gsteel
laminas-servicemanager was added as hard dependency here: d910177 (#57)
Two problems arise from this:

  1. The standalone extension manager are useless duplications (reader and writer)
  2. The component is pinned to version 1.0 of the PSR container interface

Any idea how we can solve the dependency?

@gsteel
Copy link
Member

gsteel commented Jul 20, 2023

The only way to avoid getting pinned to container:1 is, as you mentioned, the un-released service manager v4, or, dropping the hard dependency on service manager.

I've added a patch which does the latter in #76 - if that works, we can release a minor yes?

@Ocramius Ocramius added this to the 2.21.0 milestone Jul 24, 2023
@Ocramius
Copy link
Member

Closing here, handled in #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants