Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Dependency of laminas/laminas-servicemanager can be removed #27

Closed
boesing opened this issue Jan 5, 2023 · 3 comments · Fixed by #33
Closed

Dependency of laminas/laminas-servicemanager can be removed #27

boesing opened this issue Jan 5, 2023 · 3 comments · Fixed by #33
Assignees

Comments

@boesing
Copy link
Member

boesing commented Jan 5, 2023

Feature Request

Q A
BC Break no

Summary

Hey there, I realized that this component still depends on servicemanager while it provides its own ContainerInterface implementation.

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee.
If you have a security issue, please follow our security reporting guidelines.
If you wish to take on the role of maintainer, please nominate yourself

@github-actions github-actions bot closed this as completed Jan 5, 2023
@Ocramius
Copy link
Member

Ocramius commented Jan 5, 2023

This one?

class PaddingPluginManager implements ContainerInterface

Yep, we can drop the dependency 👍

Note that upgrading to psr/container:^2 is trickier, because the implementations are not final

@gsteel
Copy link
Member

gsteel commented Jul 17, 2024

Closed via #33

@gsteel gsteel closed this as completed Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants