Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZF3] Remove StorageFactory and PatternFactory #4

Closed
weierophinney opened this issue Dec 31, 2019 · 2 comments
Closed

[ZF3] Remove StorageFactory and PatternFactory #4

weierophinney opened this issue Dec 31, 2019 · 2 comments

Comments

@weierophinney
Copy link
Member

Hey there,

I would like to drop those abstract factories in favor of using the related PluginManagers directly.
Since #93 introduces external packages, it will get more and more difficult to attach plugins/storage adapters to the PluginManagers, if not retrieved by the projects ContainerInterface.

Imho, each external package should provide their own factories for their plugins/storage adapters and just inject these to the related PluginManager (e.g. by using delegators? Some feedback would be great).

The original idea of @marc-mabe was to use the Module object to add aliases and factories to the PluginManager but as of zend-config-aggregator or in projects without zend-mvc, this wont work anymore.

I would appreciate to get some feedback on this.
@weierophinney


Originally posted by @boesing at zendframework/zend-cache#175

@weierophinney
Copy link
Member Author

The idea makes sense, but removal is a hard BC break - can you maybe send a PR with deprecations for the classes you are targeting?


Originally posted by @Ocramius at zendframework/zend-cache#175 (comment)

@boesing
Copy link
Member

boesing commented Nov 8, 2020

I'll mark these factories as deprecated in v3 and remove them in v4 as of #49 and #50
In case of #49, there is a new factory which provides new service to create storage adapters in a convenient way.

@boesing boesing closed this as completed Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants