Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Erc20 Fetcher mandatory and have a no-op implementation that always returns 1 #192

Closed
jrchatruc opened this issue Feb 26, 2024 · 1 comment
Closed

Make the Erc20 Fetcher mandatory and have a no-op implementation that always returns 1 #192

jrchatruc opened this issue Feb 26, 2024 · 1 comment
Assignees
@juan518munoz
Labels
erc20-base-token

Comments

@jrchatruc
Copy link
Collaborator

🌟 Feature Request

Instead of making the Erc20Fetcher an option (where it only runs in the case of a non-eth base token), make it mandatory and add a default No-Op implementation that always returns Ok(1) in the case where eth is the native token.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juan518munoz juan518munoz

Labels
erc20-base-token
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrchatruc @juan518munoz