You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are using cairo-rs to build a cairo testing suite.
We are extending the VM with custom behaviors using hints (and other stuff).
We would like to be able to have our custom logic return specific custom VirtualMachineError.
Right now the only way to do so is to use the VirtualMachineError::CustomHint(String) variant.
Problem:
it only take a String, no custom error types
for our "other stuff" that are not hints it's a smell to use something called CustomHint, yet it's the only thing we have now.
Our ideal implementation would be something like this: VirtualMachineError::Other(Box<dyn Error>) or VirtualMachineError::Other(anyhow::Error) (if you don't mind the dependency)
If the lambdaclass team agrees, we can come up with a PR for this.
The text was updated successfully, but these errors were encountered:
We are using cairo-rs to build a cairo testing suite.
We are extending the VM with custom behaviors using hints (and other stuff).
We would like to be able to have our custom logic return specific custom VirtualMachineError.
Right now the only way to do so is to use the
VirtualMachineError::CustomHint(String)
variant.Problem:
CustomHint
, yet it's the only thing we have now.Our ideal implementation would be something like this:
VirtualMachineError::Other(Box<dyn Error>)
orVirtualMachineError::Other(anyhow::Error)
(if you don't mind the dependency)If the lambdaclass team agrees, we can come up with a PR for this.
The text was updated successfully, but these errors were encountered: