-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make benchmarks more realistic #49
Comments
@TheNeikos would you be interested in this issue? I know you're working on a website that uses Maud; that project could be a good source to draw from. |
Hm, right now I'm doing something similar to Rails (cause I like their way of organizing things):
I wouldn't mind generalizing it a bit and making a benchmark for it, although I am not sure what one would benchmark in that case. Nested |
It's great that you're interested in this sort of thing! My goals with these benchmarks are twofold:
Horrorshow, in particular, still uses a method based on writers/closures, rather than returning a In other words, benchmarking your way of doing it is not out of scope. I think copying the code from a reasonably-complex view, and calling it would some hard-coded data, would make a decent benchmark. |
Alright, I will do that then. 👍 |
Hm... Sorry that I didn't come back to you yet. I forgot to put it on my to-do list and it slipped my mind. It is there now though, so you should get the start of a PR tonight (GMT+2 once I'm home from work). |
I don't think there's anything else to do for this issue. |
The existing benchmarks are okay, but a bit simplistic. I'd love to have code that reflects the kind of use cases we see in the real world.
The text was updated successfully, but these errors were encountered: