Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor contrast on home folder icon #12

Open
lah7 opened this issue Oct 9, 2019 · 1 comment
Open

Poor contrast on home folder icon #12

lah7 opened this issue Oct 9, 2019 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed icons Affects the colourized icon theme script bug Something isn't working with the script

Comments

@lah7
Copy link
Owner

lah7 commented Oct 9, 2019

Only a handful of themes have a clear contrast.

Original ❌ ✔️
Screenshot_20191009_132657 Screenshot_20191009_132344 Screenshot_20191009_132525

Likely one of the colour light/dark variables produce a too similar and need adjustment.
@lah7 lah7 added script bug Something isn't working with the script good first issue Good for newcomers icons Affects the colourized icon theme labels Oct 9, 2019
@lah7
Copy link
Owner Author

lah7 commented Oct 31, 2019

With the developments in #4, the original contrast is no longer an issue 👍

Although, it seems across the board, the colours for this particular icon are still quite light -but it could just be the nature of these colours being more vibrant.

image

The original:

Screenshot_20191031_230246

@lah7 lah7 added the help wanted Extra attention is needed label Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed icons Affects the colourized icon theme script bug Something isn't working with the script
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lah7