Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle nil for DOIs stored in session store #37

Closed
mfenner opened this issue Sep 7, 2014 · 2 comments
Closed

Properly handle nil for DOIs stored in session store #37

mfenner opened this issue Sep 7, 2014 · 2 comments
Assignees
@mfenner
Labels
bug
Milestone
ALM Reports 2.1

Comments

@mfenner
Copy link
Member

mfenner commented Sep 7, 2014 

[FATAL] NoMethodError (undefined method `length' for nil:NilClass):
  app/controllers/application_controller.rb:130:in `articleLimitReached?'
  app/controllers/id_controller.rb:14:in `index'
  app/controllers/application_controller.rb:105:in `save_session_dois' (pid:27493)

This is related to #34.
@mfenner mfenner added the bug label Sep 7, 2014
@mfenner mfenner added this to the Iteration 2 milestone Sep 7, 2014
@mfenner mfenner self-assigned this Sep 10, 2014
This was referenced Sep 15, 2014
Closed
Merged
@mfenner
Copy link
Member Author

mfenner commented Sep 20, 2014

This has been fixed in pull request #43.

@mfenner mfenner closed this as completed Sep 20, 2014
@jure
Copy link
Contributor

jure commented Sep 20, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfenner mfenner

Labels
bug
Projects
None yet
Milestone
ALM Reports 2.1
Development

No branches or pull requests
2 participants
@mfenner @jure