Request.parse / this._parser not used for browser?

[benmosher]

this._parser is set in request-base.js via parse method, but is only used in lib/node/index.js.

It seems like _parseBody in client.js should use it, but it doesn't.

Is this a bug? It appears that maybe this is similar to (or a continuation of) #805?

Also noteworthy and related: buffer(true|false) is not available in the browser.

[kornelski]

Neither buffering, nor response body parsing are available in the browser. These things are handled natively by XHR.

In Node parser is expected to listen to events on response stream, but in the browser we don't have a stream (we could #1033)

[benmosher]

Ah, so makes sense that buffer(...) would be unavailable within browser.

It still seems like providing a parser via #parse should be used within _parseBody as an override for the global request.parse map?

Current code:

// lib/client.js:375
Response.prototype._parseBody = function(str){
  var parse = request.parse[this.type];
  if (!parse && isJSON(this.type)) {
    parse = request.parse['application/json'];
  }
  return parse && str && (str.length || str instanceof Object)
    ? parse(str)
    : null;
};

What I thought I'd find based on #parse docs:

// lib/client.js:375
Response.prototype._parseBody = function(str){
  var parse = this._parser || request.parse[this.type]; // only changed this line
  if (!parse && isJSON(this.type)) {
    parse = request.parse['application/json'];
  }
  return parse && str && (str.length || str instanceof Object)
    ? parse(str)
    : null;
};

[niftylettuce]

v5.0.0 was released and should fix this issue, see the updated docs