Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Trigger to support the inverted kwarg #109

Open
philipstarkey opened this issue Feb 17, 2024 · 0 comments
Open

Update Trigger to support the inverted kwarg #109

philipstarkey opened this issue Feb 17, 2024 · 0 comments

Comments

@philipstarkey
Copy link
Member

It looks like Trigger was written without considering the DigitalOut inverted kwarg. This potentially leads to some confusing behaviour, see #93.

We should look at fixing this so it is consistent. However, case needs to be taken to ensure it is backwards compatible, particularly with PulseBlaster's as secondary pseudoclocks (as PulseBlasters have inverted digital triggers and Trigger was likely written specifically for that use case).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philipstarkey