Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create new container mount when force override (#4068) (#4072) #4079

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: create new container mount when force override (#4068) (#4072) #4079

merged 1 commit into from
Oct 12, 2023

Conversation

cuisongliu
Copy link
Collaborator

@cuisongliu cuisongliu commented Oct 11, 2023 •
edited by ghost
Loading

(cherry picked from commit 4242e7c)

🤖 Generated by Copilot at e6934f9

Summary

🧹🐛🚀

Fixed container override bug and removed unused code in processor package. This improves the reliability and maintainability of the apply command.

Sing, O Muse, of the skillful coder who refined his craft
And purged his code of rand, the needless and the chaff
He fixed the logic of the processor, that mighty tool
And made it shun the old containers, like a wise and prudent mule

Walkthrough

  • Fix bug and simplify code in PreProcess function by deleting existing container with same name as image to be overridden (link, F0

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@sealos-ci-robot @fengxsong @cuisongliu
fix: create new container mount when force override (labring#4068) (l…
9398bb1 
…abring#4072)

Signed-off-by: fengxsong <[email protected]>
Co-authored-by: fengxsong <[email protected]>

(cherry picked from commit 4242e7c)
Signed-off-by: cuisongliu <[email protected]>
@cuisongliu cuisongliu added this to the cherry-pick milestone Oct 12, 2023
@cuisongliu cuisongliu merged commit 34236b4 into labring:release-v4.3 Oct 12, 2023
68 checks passed
@cuisongliu cuisongliu deleted the fix_CONFLICT_#4072 branch October 12, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengxsong fengxsong fengxsong approved these changes

Assignees
No one assigned
Labels
area/apply sealos run/apply/scale/reset area/lifecycle-management size/S
Projects
None yet
Milestone
cherry-pick
Development

Successfully merging this pull request may close these issues.
3 participants
@cuisongliu @fengxsong @sealos-ci-robot