fix: scp files #4041
Merged
fix: scp files #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated by lychee actionSummary
Full action output |
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
fengxsong
requested changes
Oct 8, 2023
pkg/ssh/scp.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("failed to create: %v", err) | ||
| destTmp := dest + ".tmp" | ||
| copyToTmp := func(tmpName string) error { |
There was a problem hiding this comment.
if err = func() error {
......
}(); err!=nil {
}
using anonymous function is just fine.
fengxsong
approved these changes
Oct 8, 2023
|
/cherry-pick release-v4.4 |
|
🤖 says: cherry pick action finished successfully 🎉! |
sealos-ci-robot
pushed a commit
that referenced
this pull request
Oct 8, 2023
* fix: scp files * fix: scp files * fix: scp files * fix: scp files
cuisongliu
pushed a commit
that referenced
this pull request
Oct 8, 2023
* fix: scp files * fix: scp files * fix: scp files * fix: scp files Co-authored-by: 榴莲榴莲 <[email protected]>
sealos-ci-robot
added a commit
that referenced
this pull request
Oct 8, 2023
* fix: scp files * fix: scp files * fix: scp files * fix: scp files Co-authored-by: 榴莲榴莲 <[email protected]>
bxy4543
reviewed
Oct 8, 2023
| return fmt.Errorf("failed to Chmod dst: %v", err) | ||
| destTmp := dest + ".tmp" | ||
| if err = func(tmpName string) error { | ||
| dstfp, err := client.Create(tmpName) |
cuisongliu
pushed a commit
that referenced
this pull request
Oct 8, 2023
* fix: scp files * fix: scp files * fix: scp files * fix: scp files Co-authored-by: 榴莲榴莲 <[email protected]>
bxy4543
pushed a commit
to bxy4543/sealos
that referenced
this pull request
Oct 13, 2023
* fix: scp files * fix: scp files * fix: scp files * fix: scp files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix scp files