Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): fix unable to delete dependency name with splash #786 #805

Merged
merged 2 commits into from
Feb 20, 2023
Merged

fix(server): fix unable to delete dependency name with splash #786 #805

merged 2 commits into from
Feb 20, 2023

Conversation

sulnong
Copy link
Contributor

@sulnong sulnong commented Feb 18, 2023

No description provided.

@sulnong sulnong requested review from maslow and LeezQ February 18, 2023 09:50
@maslow maslow changed the title fix(delete dependency): fix unable to delete dependency name with splash #786 fix(server): fix unable to delete dependency name with splash #786 Feb 20, 2023
@sulnong
Copy link
Contributor Author

sulnong commented Feb 20, 2023

@maslow changed dependency name acquire method, use body in delete request

@sulnong
Copy link
Contributor Author

sulnong commented Feb 20, 2023 •
edited
Loading

@sulnong Why is it modified like this ？

previous delete controller is /v1/:appid/dependencies/:dependency-name
but if a dependency named @types/node, the extra splash / can not match controller above
so changed route from /v1/:appid/dependencies/:dependency-name to /v1/:appid/dependencies, deliver dependency name by using delete body insteaded of dynamic match

maslow
maslow approved these changes Feb 20, 2023
View reviewed changes
@maslow maslow merged commit 0472a65 into labring:main Feb 20, 2023
@sulnong sulnong deleted the fix-delete-package-with-slash branch February 24, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maslow maslow maslow approved these changes

@LeezQ LeezQ Awaiting requested review from LeezQ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sulnong @maslow