feat(gateway): add gateway crds #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
skyoct
commented
Aug 27, 2022
skyoct
commented
- add gateway crds
maslow
requested changes
Aug 27, 2022
| // Nodes 是节点列表，必须存在，至少有一个节点, 每个节点是个key-value对，key是节点名称，value是节点权重 | ||
| // +kubebuilder:validation:MinItems=1 | ||
| // +kubebuilder:validation:Required | ||
| Nodes []map[string]int32 `json:"nodes"` |
There was a problem hiding this comment.
这个 Node 应该直接用 serviceName 和 servicePort 吧， 并不需要我们关心负载均衡， 那上 k8s service 的事情， 在这里我们只要转发到 service 上就可以了
| // Important: Run "make" to regenerate code after modifying this file | ||
|
|
||
| // RouteType 是路由类型, 必须存在，且只能是下面的值之一 oss、website、app | ||
| // +kubebuilder:validation:Enum=oss;website;app |
|
@maslow 已更新 |
maslow
approved these changes
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.