Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behaviour with $this->isRoot results in composer-dev-symlink failing silently #1

Open
marvinhinz opened this issue Jan 18, 2024 · 0 comments

Comments

@marvinhinz
Copy link

Hi!

Just tried this module, as its exactly what i needed, thanks a lot!

But i ran in to a problem where the hooks were not fired, it was because of the $this->isRoot check.

After a bit of debugging i found out our repos that require a shared module dont have names in the composer.json, this comment helped me composer/composer#7089 (comment)

Is that behaviour intended or is this maybe a confusion when __root__ is returned? After adding the name to my project, this plugin works flawless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant