Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+2 ISSUE #40 #40

Open
Scott-Crawford opened this issue Apr 15, 2018 · 0 comments
Open

+2 ISSUE #40 #40

Scott-Crawford opened this issue Apr 15, 2018 · 0 comments

Comments

@Scott-Crawford
Copy link

  1. It is not stated whether blank lines should increment the line counter in either REPL or file mode.

  2. In the errors for REPL, "LET A" outputs "Operator LET applied to empty stack". However, "LET" is a keyword. Shouldn't this be an error code 5 instead?

Laboon's Response:

  1. This is ambiguous based on the requirements (since I say "blank lines should be ignored") but I would say that even blank lines increment the counter.

  2. Good point. The way I wrote it, both keywords and operators do the same "kind" of thing and I didn't differentiate. Ideally it should be error code 5 but I would be content with either way of doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant