Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Upgrade the image version of the macOS runner #3148

Closed
wants to merge 1 commit into from

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Nov 27, 2024

actions/runner-images#10721
Support for macOS 12 has been discontinued.
Upgrade your version as that runner image will be removed soon.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@Yaminyam Yaminyam added this to the 23.09 milestone Nov 27, 2024
@Yaminyam Yaminyam requested a review from achimnol November 27, 2024 04:24
@github-actions github-actions bot added the size:XS ~10 LoC label Nov 27, 2024
@Yaminyam Yaminyam added the skip:changelog Make the action workflow to skip towncrier check label Nov 27, 2024
os: [ubuntu-latest, ubuntu-22.04-arm64, macos-13-xlarge, macos-12-large]
# macos-13: intel
# macos-14: apple silicon
os: [ubuntu-latest, ubuntu-22.04-arm64, macos-13, macos-14]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the instance size used to be specified, is there a reason it's missing? @Yaminyam

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, arm mac runners were only supported on larger runners.
However, we've changed that because we now support it in regular runners as well.

Copy link
Collaborator

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@achimnol
Copy link
Member

achimnol commented Jan 5, 2025

Oops, I've missed this PR.
Resolved in #3367!

@achimnol achimnol closed this Jan 5, 2025
@Yaminyam Yaminyam deleted the ci/upgrade-macos-runner branch January 22, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants