-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement m2m table for container_registries
, and groups
#3065
base: main
Are you sure you want to change the base?
feat: Implement m2m table for container_registries
, and groups
#3065
Conversation
depends_on = None | ||
|
||
|
||
def upgrade() -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, there was no per-project image lookup functionality, so data migration logic will be unnecessary here.
AssociationContainerRegistriesGroupsRow
container_registries
, and groups
src/ai/backend/manager/models/association_container_registries_groups.py
Outdated
Show resolved
Hide resolved
src/ai/backend/manager/models/association_container_registries_groups.py
Outdated
Show resolved
Hide resolved
b255920
to
c1c349c
Compare
b2abda9
to
6004978
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding the new table definition in an existing file such as models/container_registries.py
or models/groups.py
? This is just a suggestion, you don't need to reflect it right away.
src/ai/backend/manager/models/association_container_registries_groups.py
Show resolved
Hide resolved
d4ce974
to
bebc68e
Compare
Personally, I think it’s better to place them in separate files. |
5e6f6ed
to
5cad46c
Compare
5cad46c
to
3069cc8
Compare
Implement
AssociationContainerRegistriesGroups
as m2m table ofcontainer_registries
, andgroups
for resolving #1908.Note
#1908 mentions both user and project, but since project needs to be implemented first, this PR stack addresses only the project aspect.
Refer to #1960 for adding an association table with the User table and related tasks.
Checklist: (if applicable)