Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pydantic-based local configuration schema #2764

Open
4 tasks
achimnol opened this issue Aug 24, 2024 · 0 comments
Open
4 tasks

Migrate to pydantic-based local configuration schema #2764

achimnol opened this issue Aug 24, 2024 · 0 comments
Labels
type:refactor Refactor codes or add tests.
Milestone

Comments

@achimnol
Copy link
Member

achimnol commented Aug 24, 2024

Along with #2760, we found that there is a deviation between wsproxy and other server packages: pydantic-based vs. trafaret-based local-config schema.

Let's migrate our local configs to pydantic.

  • Prerequisite: Split out ai.backend.typeutils and ai.backend.types packages.
  • Migrate ai.backend.logging.config to use pydantic-based schema as well.
  • wsproxy.cli.context.CLIContext: Let it respect the local logging configuration if present and silently fallback to a default config like other server components. (remaining of Wrong Implicit log level overridding when --log-level argument is not provided #2759)
  • Rewrite all local config schema of other server packages like wsproxy.
@achimnol achimnol added the type:refactor Refactor codes or add tests. label Aug 24, 2024
@achimnol achimnol added this to the Backlog milestone Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:refactor Refactor codes or add tests.
Projects
None yet
Development

No branches or pull requests

1 participant