Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track segments #310

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

AlainKnaff
Copy link

Hi,

This pull request adds the possibility to have multiple segments per track ( tag in the XML file). Each time tracking is stopped and later resumed, a new segment is started. This helps avoid the clutter of unsightly lines crisscrossing the displayed track when position changes while tracking is stopped.

Thx for merging,

Alain

Alain Knaff added 3 commits May 2, 2021 21:00
Copy link
Member

@jamescr jamescr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nicer that every point get associated with a consecutive segment number and not with 0 or 1 only. What do you think?

@@ -125,7 +126,7 @@
* v17: add TBL_TRACKPOINT.COL_ATMOSPHERIC_PRESSURE and TBL_WAYPOINT.COL_ATMOSPHERIC_PRESSURE
*</pre>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update documentation:

* v18: add TBL_TRACKPOINT.COL_NEW_SEGMENT

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback

would be nicer that every point get associated with a consecutive segment number and not with 0 or 1 only. What do you think?

You mean, every segment? Yes, that would be another way to represent multiple segments.
The way the my proposal currently works is that the first point of each segment has 1 (or true), and all the following ones are false again. In a way, it is the derivative of the segment number.
However, if you have a strong preference for the other way, I can change it. However, in that case, I'll apply this to my later pull request (#312, "Import a gpx file as a route to follow"), because there is some interdependence among both. Also, please note that I will be on the move until end of August, and might not get back to this until then.

@jamescr
Copy link
Member

jamescr commented Jul 18, 2021

Alain thanks for this PR! Definitely is a great contribution

@jamescr jamescr modified the milestones: v1.0.0-rc1, 1.0.2 Jul 18, 2021
@jamescr jamescr modified the milestones: 2024.7, 2024.12 Jul 13, 2024
@Binnette Binnette changed the base branch from master to develop November 22, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants