Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpack should return an object #42

Open
ajoaoff opened this issue Jun 28, 2021 · 1 comment
Open

Unpack should return an object #42

ajoaoff opened this issue Jun 28, 2021 · 1 comment
Labels
level:medium refactoring

Comments

@ajoaoff
Copy link

ajoaoff commented Jun 28, 2021

Original issue opened by @cemsbr at kytos#130.

Refactor unpack methods to return the unpacked object instead of being an inplace method.

Probably the TODO creator meant implementing a class method so we would call FixedTypeList.unpack(buff), for instance.
@cemsbr
Copy link

cemsbr commented Jul 12, 2021

Duplicate of #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
level:medium refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cemsbr @ajoaoff @viniarck