Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introspect should also fetch column comments so we can generate typescript comments #841

Closed
maktouch opened this issue Jan 11, 2024 · 1 comment · Fixed by #842
Closed

Introspect should also fetch column comments so we can generate typescript comments #841

maktouch opened this issue Jan 11, 2024 · 1 comment · Fixed by #842
Labels
api Related to library's API built-in dialect Related to a built-in dialect enhancement New feature or request greenlit Ready for implementation

Comments

@maktouch
Copy link
Contributor

Related to RobinBlomberg/kysely-codegen#127

We need comments in the introspection, so we can generate typescript comments for the column. Would you accept a PR for this?
@maktouch maktouch mentioned this issue Jan 11, 2024
Merged
@koskimas
Copy link
Member

Would you accept a PR for this

Sure, if you provide a fully working and tested PR that implements this for all built-in dialect that support the feature.

@koskimas koskimas added greenlit Ready for implementation enhancement New feature or request built-in dialect Related to a built-in dialect api Related to library's API labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Related to library's API built-in dialect Related to a built-in dialect enhancement New feature or request greenlit Ready for implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

introspect column comments maktouch/kysely
2 participants
@koskimas @maktouch