Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eb(ref, op, val) does not accept sql template tag escaped op argument. #1012

Closed
igalklebanov opened this issue May 29, 2024 · 3 comments
Closed

eb(ref, op, val) does not accept sql template tag escaped op argument. #1012

igalklebanov opened this issue May 29, 2024 · 3 comments
Labels
api Related to library's API bug Something isn't working duplicate This issue or pull request already exists typescript Related to Typescript

Comments

@igalklebanov
Copy link
Member

Hey 👋

Seems like eb(ref, op, val) does not accept sql template tag escaped operators in 2nd argument.

image
image
https://tsplay.dev/NrYbaw

Also, these are uncaught in the kysely playground. (cc @wirekang)
@igalklebanov igalklebanov added bug Something isn't working api Related to library's API typescript Related to Typescript labels May 29, 2024
@igalklebanov igalklebanov changed the title eb(...) does not accept sql template tag escaped operators in 2nd argument. eb(ref, op, val) does not accept sql template tag escaped operators in 2nd argument. May 29, 2024
@igalklebanov igalklebanov changed the title eb(ref, op, val) does not accept sql template tag escaped operators in 2nd argument. eb(ref, op, val) does not accept sql template tag escaped op argument. May 29, 2024
@igalklebanov igalklebanov changed the title eb(ref, op, val) does not accept sql template tag escaped op argument. eb(ref, op, val) does not accept sql template tag escaped op argument. May 29, 2024
@koskimas
Copy link
Member

Isn't this a duplicate of #891? eb assumes the operator is arithmetic and returns the operand type and not bool.

@igalklebanov
Copy link
Member Author

igalklebanov commented May 29, 2024 •
edited
Loading

Oops. Forgot about it. 😮

@igalklebanov igalklebanov added the duplicate This issue or pull request already exists label May 29, 2024
@boehs boehs mentioned this issue Jun 7, 2024
Merged
@wirekang
Copy link
Contributor

wirekang commented Jun 9, 2024

Also, these are uncaught in the kysely playground.

I updated the playground to use newer version of typescript(5.0.2 ->5.4.5), it seems fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Related to library's API bug Something isn't working duplicate This issue or pull request already exists typescript Related to Typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@koskimas @igalklebanov @wirekang