Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove loki output #873

Closed
a-thaler opened this issue Mar 11, 2024 · 3 comments · Fixed by #1437
Closed

Remove loki output #873

a-thaler opened this issue Mar 11, 2024 · 3 comments · Fixed by #1437
Assignees
@hisarbalik
Labels
area/manager Manager or module changes kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@a-thaler
Copy link
Collaborator

a-thaler commented Mar 11, 2024 •
edited
Loading

Description

As follow up of the disabled loki output (#461), the output should get removed finally. The API was not usable for nearly one year and not documented anywhere, so it can be safely removed.

Criterias

  • Verify that there is no cluster using the output
  • There is no loki output in the alpha and beta version available
  • No occurence of the API is available in the docu, code, tests
  • Validation/reason is cleaned up

Reasons

Attachments

Release Notes
@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/manager Manager or module changes labels Mar 11, 2024
@a-thaler a-thaler mentioned this issue Mar 6, 2024
Open
20 tasks
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically closed due to the lack of recent activity.
/lifecycle rotten

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2024
@kyma-bot kyma-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 26, 2024
@skhalash skhalash reopened this May 26, 2024
@skhalash skhalash added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels May 26, 2024
@a-thaler a-thaler changed the title Remove loki output from logs beta version and introduce initial conversion webhook for beta version Remove loki output Aug 27, 2024
@hisarbalik hisarbalik self-assigned this Sep 11, 2024
@hisarbalik hisarbalik mentioned this issue Sep 11, 2024
Merged
5 tasks
@hisarbalik hisarbalik linked a pull request Sep 11, 2024 that will close this issue
feat: Remove LogPipeline loki output #1437
Merged
5 tasks
@hisarbalik
Copy link
Contributor

  • The grafana-loki output removed from both versions of LogPipeline removed
  • The test and validation code related to the grafana-loki removed
  • The grafana-loki output was removed from documents and examples
  • All customer clusters from all environments checked for the existence of LogPipelines with grafana-loki output, and no occurrence was found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hisarbalik hisarbalik

Labels
area/manager Manager or module changes kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Remove LogPipeline loki output hisarbalik/telemetry-manager
4 participants
@skhalash @hisarbalik @a-thaler @kyma-bot