Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System namespaces are always excluded in LogPipeline #778

Closed
chrkl opened this issue Feb 7, 2024 · 1 comment
Closed

System namespaces are always excluded in LogPipeline #778

chrkl opened this issue Feb 7, 2024 · 1 comment
Assignees
Labels
area/logs LogPipeline kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@chrkl
Copy link
Contributor

chrkl commented Feb 7, 2024

Description

The LogPipeline CRD allows to configure included and excluded namespaces and has a shortcut to include system namespaces. The three options are mutually exclusive. The generated Fluent But configuration always excludes the system namespaces if the system flag is not set. This prevents to create a configuration that includes system and custom namespaces in the include list.

Expected result

Creating a LogPipeline with

...
spec:
  input:
    application:
      namespaces:
        include:
        - kube-system
        - kyma-system
        - foo
...

should result in the following tail input settings

path /var/log/containers/*_kube-system_*-*.log,/var/log/containers/*_kyma-system_*-*.log,/var/log/containers/*_kyma-system_*-*.log,/var/log/containers/*_foo_*-*.log
exclude_path /var/log/containers/telemetry-fluent-bit-*_kyma-system_fluent-bit-*.log

Actual result

path /var/log/containers/*_kube-system_*-*.log,/var/log/containers/*_kyma-system_*-*.log,/var/log/containers/*_kyma-system_*-*.log,/var/log/containers/*_foo_*-*.log
exclude_path /var/log/containers/telemetry-fluent-bit-*_kyma-system_fluent-bit-*.log,/var/log/containers/*_kyma-system_*-*.log,/var/log/containers/*_kube-system_*-*.log,/var/log/containers/*_istio-system_*-*.log,/var/log/containers/*_compass-system_*-*.log

All system namespaces are part of the exclude_path list, so the user-defined include list is not effective.

Release Notes


@chrkl chrkl added kind/bug Categorizes issue or PR as related to a bug. area/logs LogPipeline labels Feb 7, 2024
@chrkl chrkl added this to the 1.9.0 milestone Feb 7, 2024
@chrkl chrkl self-assigned this Feb 7, 2024
@chrkl
Copy link
Contributor Author

chrkl commented Feb 8, 2024

Fixed by PR #779

@chrkl chrkl closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant