Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce initial conversion webhook for beta version #1391

Closed
a-thaler opened this issue Aug 27, 2024 · 1 comment
Closed

Introduce initial conversion webhook for beta version #1391

a-thaler opened this issue Aug 27, 2024 · 1 comment
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@a-thaler
Copy link
Collaborator

a-thaler commented Aug 27, 2024

Description

In preparation of applying the beta API changes (#767), a conversion webhook needs to get established as part of the experimental release.

Criterias

  • There is a conversion webhook in place which gets called on any beta API LogPipeline queries only
  • kubebuilder approach for conversion webhooks is in use
  • The webhook uses the same cert mechanism as the existing validation webhook, so that no cert expiry can happen
  • The webhook is only active for the experimental release
  • Rename and covert the LogPipeline.input.application attribute and add the "enabled" attribute as outlined in LogPipeline Beta API #1395
  • Re-use the existing crypto logic for certificate handling

Reasons

Attachments

Release Notes


@a-thaler a-thaler added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2024
@a-thaler a-thaler mentioned this issue Aug 27, 2024
20 tasks
@skhalash skhalash self-assigned this Sep 16, 2024
@skhalash
Copy link
Collaborator

The conversion webhook infrastructure has been set up, but its functionality is currently limited—it only renames the application input to runtime. One open question remains: how should we monitor this setup (e.g., alerts, dashboards, etc.)? While controller-runtime offers webhook metrics, which we are already scraping, we need to further define a comprehensive monitoring approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants