Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Buildless mode shouldn't duplicate managed resources #1407

Open
kwiatekus opened this issue Jan 22, 2025 · 0 comments
Open

Enabling Buildless mode shouldn't duplicate managed resources #1407

kwiatekus opened this issue Jan 22, 2025 · 0 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@kwiatekus
Copy link
Contributor

kwiatekus commented Jan 22, 2025

Description

I had few functions created with serverless 1.6.7. I migrated serverless operator to latest from main and enabled builddless mode.

Buildless-variant added its own products of function reconciliation instead of inheriting those resources created and managed by function-controller

I think preserving the function-controller, when tagging managed resources by buildldess variant of serverless, would help keeping the continuity in resource management.

kubectl get pods -L serverless.kyma-project.io/managed-by

NAME                               READY   STATUS      RESTARTS   AGE     MANAGED-BY
node-5859c9bcdd-hllk8              1/1     Running     0          4m4s    buildless-function-controller
node-89xkm-7fccb9684c-zscgg        1/1     Running     0          6h11m   function-controller
node-build-7qjdp-xdldg             0/1     Completed   0          6h11m   function-controller
nodejs18-build-kgc4c-22mbg         0/1     Completed   0          4h28m   function-controller
nodejs18-x7cqt-6c47f8569f-2xjt7    1/1     Running     0          4h28m   function-controller
python-6j57g-7d6fcf9ddd-9dc2f      1/1     Running     0          82m     function-controller
python-7d84f4b5c5-k5dwj            1/1     Running     0          4m4s    buildless-function-controller
python-build-s8892-kx29c           0/1     Completed   0          82m     function-controller
swapi-787bb8c6b-c8zpv              1/1     Running     0          4m4s    buildless-function-controller
swapi-7xfpk-547b5bb644-29rcr       1/1     Running     0          81m     function-controller
swapi-build-jfmpp-fzqc2            0/1     Completed   0          82m     function-controller
wrong-resources-55bc847bdb-wkr97   1/1     Running     0          4m4s    buildless-function-controller

Additionally please make sure ALL resources managed by buildless do have proper label.
For examle, atm services do not have the label


k get svc -L serverless.kyma-project.io/managed-by
NAME         TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)   AGE     MANAGED-BY
kubernetes   ClusterIP   10.104.0.1       <none>        443/TCP   24h     
node         ClusterIP   10.105.23.51     <none>        80/TCP    6h43m   
nodejs18     ClusterIP   10.106.191.229   <none>        80/TCP    4h43m   function-controller
python       ClusterIP   10.106.240.52    <none>        80/TCP    6h43m   
python-new   ClusterIP   10.108.117.191   <none>        80/TCP    51s     
swapi        ClusterIP   10.111.187.233   <none>        80/TCP    140m    
@kwiatekus kwiatekus added the kind/bug Categorizes issue or PR as related to a bug. label Jan 22, 2025
@kwiatekus kwiatekus changed the title Migration srvls 1.6.7 -> buildless (main) shouldn't leave old function pods Migration srvls 1.6.7 -> buildless (main) shouldn't duplicate managed resources Jan 22, 2025
@kwiatekus kwiatekus changed the title Migration srvls 1.6.7 -> buildless (main) shouldn't duplicate managed resources Enabling Buildless mode shouldn't duplicate managed resources Jan 22, 2025
@MichalKalke MichalKalke self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants